Skip to content

Arm backend: Add full partition rejections #12995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Jul 30, 2025

  • Reject partitions that will be lowered to empty subgraphs, i.e. containing only clones/ noop expands.

    • Fix a bug exposed by the partition fix causing a infinite recursion search for qparams when mixing shared qspec ops and arithmetic ops.
    • For eye/one/zeros the graph is not really empty since it contains one constant, and this works now. Simply move the previosuly xfailing tests to MI/BI. (u55/ u85 still fails because of missing CPU ops)
  • Reject partitions with non supported memory formats instead of failing these.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Reject partitions that will be lowered to empty subgraphs,
  i.e. containing only clones/ noop expands.
  - Fix a bug exposed by the partition fix causing a infinite
    recursion search for qparams when mixing shared qspec ops
    and arithmetic ops.
  - For eye/one/zeros the graph is not really empty since it
    contains one constant, and this works now. Simply move the
    previosuly xfailing tests to MI/BI. (u55/ u85 still fails
    because of missing CPU ops)

- Reject partitions with non supported memory formats instead of
  failing these.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: Iefa034a8e731d70465eb4883602c958f51aca976
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jul 30, 2025
Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12995

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 12 New Failures, 4 Unrelated Failures

As of commit 12f2928 with merge base 90ff059 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
@zingo
Copy link
Collaborator

zingo commented Jul 31, 2025

Need a rebase, sorry :(

@AdrianLundell
Copy link
Collaborator Author

AdrianLundell commented Aug 6, 2025

I'll wait with this PR until #12994 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants