Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 10, 2025

Summary

After meta-pytorch/tokenizers#121 and #13888, we should be able to enable tokenizers on Windows.

Test plan

CI. Also verified that install functions on a local Windows machine.

cc @larryliu0820

Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14180

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit caafb73 with merge base f1ca55a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@GregoryComer GregoryComer added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: windows labels Sep 10, 2025
@GregoryComer GregoryComer added this to the 1.0.0 milestone Sep 10, 2025
@GregoryComer GregoryComer mentioned this pull request Sep 11, 2025
20 tasks
@GregoryComer
Copy link
Member Author

I'm seeing some path length issues when building tokenizers in-place. I'm going to see if I can set up a symlink in the windows setup CI script.

@GregoryComer GregoryComer force-pushed the reenable-tokenizers-windows branch from f07394e to 3434543 Compare September 11, 2025 21:13
@GregoryComer
Copy link
Member Author

Rebasing to test with #13923 to be safe, but will land today if everything looks good.

@GregoryComer GregoryComer force-pushed the reenable-tokenizers-windows branch 8 times, most recently from 679527d to 80da2d4 Compare September 12, 2025 04:09
@GregoryComer GregoryComer force-pushed the reenable-tokenizers-windows branch from 80da2d4 to caafb73 Compare September 12, 2025 04:27
@GregoryComer GregoryComer removed this from the 1.0.0 milestone Sep 12, 2025
@GregoryComer
Copy link
Member Author

Removing 1.0 milestone from this PR in favor of using the pip package, when available. I'd need to make some more aggressive infra changes to the wheel build to make this work when building from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants