-
Notifications
You must be signed in to change notification settings - Fork 667
[Windows] Re-enable tokenizers #14180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Windows] Re-enable tokenizers #14180
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14180
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit caafb73 with merge base f1ca55a ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I'm seeing some path length issues when building tokenizers in-place. I'm going to see if I can set up a symlink in the windows setup CI script. |
f07394e
to
3434543
Compare
Rebasing to test with #13923 to be safe, but will land today if everything looks good. |
679527d
to
80da2d4
Compare
80da2d4
to
caafb73
Compare
Removing 1.0 milestone from this PR in favor of using the pip package, when available. I'd need to make some more aggressive infra changes to the wheel build to make this work when building from source. |
Summary
After meta-pytorch/tokenizers#121 and #13888, we should be able to enable tokenizers on Windows.
Test plan
CI. Also verified that install functions on a local Windows machine.
cc @larryliu0820