Rename reference to generic and unify namespaces #14239
Open
+315
−558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcremon-meta
requested review from
larryliu0820 and
kirklandsign
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14239
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1c6d06f with merge base 4a4f5a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
This PR needs a
|
ethansfng
approved these changes
Sep 12, 2025
DrJessop
approved these changes
Sep 12, 2025
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: hsharma35
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
added a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
mcremon-meta
force-pushed
the
export-D82231105
branch
from
0131f33 to
87d1dc6
Compare
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
force-pushed
the
export-D82231105
branch
from
87d1dc6 to
712e898
Compare
mcremon-meta
added a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
added a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
mcremon-meta
force-pushed
the
export-D82231105
branch
from
712e898 to
ab7193f
Compare
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
added a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
mcremon-meta
force-pushed
the
export-D82231105
branch
from
ab7193f to
52136c8
Compare
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 12, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 15, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
added a commit
that referenced
this pull request
Sep 15, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
mcremon-meta
force-pushed
the
export-D82231105
branch
from
52136c8 to
eebe8b6
Compare
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
added a commit
that referenced
this pull request
Sep 15, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
mcremon-meta
force-pushed
the
export-D82231105
branch
from
eebe8b6 to
75d9f6d
Compare
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 15, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
Summary: Update dtypes for function xa_nn_conv1d_std_asym8xasym8 call Differential Revision: D82462394
mcremon-meta
pushed a commit
that referenced
this pull request
Sep 15, 2025
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
Summary: Pull Request resolved: #14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Reviewed By: ethansfng, hsharma35, DrJessop Differential Revision: D82231105
ethansfng
pushed a commit
to ethansfng/executorch
that referenced
this pull request
Sep 16, 2025
Summary: Pull Request resolved: pytorch#14239 As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that. Differential Revision: D82231105 Reviewed By: ethansfng, hsharma35, DrJessop
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82231105. |
mcremon-meta
force-pushed
the
export-D82231105
branch
from
75d9f6d to
1c6d06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that.
Reviewed By: hsharma35
Differential Revision: D82231105