Skip to content

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Sep 12, 2025

  • Insert transposes for input/output iff the incoming/outgoing data is
    in channels first format.
  • For testing using tosa_reference_mode, transpose numpy arrays to and
    from correct data format since numpy doesn't have the concept of
    dim_order.
  • Remove checks for channels_first only input.
  • Remove check for not changing dim_order before to_tosa_memory_format
    pass since the behaviour of channel last tensors is non-predictable.
  • Add dim order testing of example networks and mv2
  • Add a section to the documentation about memory formats.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

mergennachin and others added 2 commits September 11, 2025 15:32
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193
- Insert transposes for input/output iff the incoming/outgoing data is
  in channels first format.
- For testing using tosa_reference_mode, transpose numpy arrays to and
  from correct data format since numpy doesn't have the concept of
  dim_order.
- Remove checks for channels_first only input.
- Remove check for not changing dim_order before to_tosa_memory_format
  pass since the behaviour of channel last tensors is non-predictable.
- Add dim order testing of example networks and mv2
- Add a section to the documentation about memory formats.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: I05548b9f3b4671da6faad90a9dd7366fda4498d6
@AdrianLundell AdrianLundell added this to the 1.0.0 milestone Sep 12, 2025
@AdrianLundell AdrianLundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 12, 2025
@AdrianLundell AdrianLundell added ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Sep 12, 2025
Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14259

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Cancelled Jobs, 1 Unrelated Failure

As of commit bccaa2a with merge base 897b0d5 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@zingo
Copy link
Collaborator

zingo commented Sep 14, 2025

As #14191 has been merged I rebased this PR to "clean" out #14191 from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants