Skip to content

Conversation

haowhsu-quic
Copy link
Collaborator

Summary

Fixes #14048
Fixes #14049
Fixes #14050
Fixes #14051
Fixes #14052

Test plan

MATRIX = {convnext_small, maxvit_t, swin_v2_t, vit_b_16}

python backends/qualcomm/tests/test_qnn_delegate.py TestExampleOssScript.test_${MATRIX} -b build-android/ -m SM8750 -s $SN -a /path/to/test_artifacts/ -i /path/to/imagenet_1k/imagenet-mini/val -r .
python backends/qualcomm/tests/test_qnn_delegate.py TestQuantizedModel.test_qnn_backend_conformer -b build-android/ -m SM8750 -s $SN -a /path/to/test_artifacts/

- pytorch#14048 > add quantized test case with GLU decomposition
- pytorch#14049 > add e2e example where constant expansion is applied
- pytorch#14050 > add e2e example and source transform for 6D operation
- pytorch#14051 > add e2e example and complement missed annotation
- pytorch#14052 > add e2e example and dedicated passe for 6D partition
Copy link

pytorch-bot bot commented Sep 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14378

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d14e489 with merge base 56659e4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D82651145.

@cccclai
Copy link
Contributor

cccclai commented Sep 17, 2025

Thanks for the fix! I think we may need some logics to block lowering rank-6 shape, because users may not know how to do it themselves

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D82651145.

@cccclai cccclai merged commit 2b54a19 into pytorch:main Sep 17, 2025
127 of 128 checks passed
@mergennachin
Copy link
Contributor

@haowhsu-quic Do you want to include this in release/1.0 branch? If so, please follow instructions in #14288

Similar to #14328

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
### Summary
- pytorch#14048 > add quantized test case with GLU decomposition
- pytorch#14049 > add e2e example where constant expansion is applied
- pytorch#14050 > add e2e example and source transform for 6D operation
- pytorch#14051 > add e2e example and complement missed annotation
- pytorch#14052 > add e2e example and dedicated passe for 6D partition


Fixes pytorch#14048
Fixes pytorch#14049
Fixes pytorch#14050
Fixes pytorch#14051
Fixes pytorch#14052

### Test plan
MATRIX = {convnext_small, maxvit_t, swin_v2_t, vit_b_16}
```bash
python backends/qualcomm/tests/test_qnn_delegate.py TestExampleOssScript.test_${MATRIX} -b build-android/ -m SM8750 -s $SN -a /path/to/test_artifacts/ -i /path/to/imagenet_1k/imagenet-mini/val -r .
```
```bash
python backends/qualcomm/tests/test_qnn_delegate.py TestQuantizedModel.test_qnn_backend_conformer -b build-android/ -m SM8750 -s $SN -a /path/to/test_artifacts/
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
4 participants