Skip to content

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Apr 18, 2024

Stack from ghstack (oldest at bottom):

Differential Revision: D56279743

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3113

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 67e6c48 with merge base 20bf0db (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Apr 18, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
SS-JIA pushed a commit that referenced this pull request Apr 18, 2024
ghstack-source-id: b6e86fb
Pull Request resolved: #3113
Copy link

pytorch-bot bot commented Apr 18, 2024

Warning: Unknown label ciflow/periodic.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk
  • ciflow/binaries
  • ciflow/binaries/all

Please add the new label to .github/pytorch-probot.yml

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Apr 18, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Apr 18, 2024
ghstack-source-id: bf04c03
Pull Request resolved: #3113
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Apr 18, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

The Vulkan Delegate libraries can be built by setting `-DEXECUTORCH_BUILD_VULKAN=ON`
when building with CMake.

First, make sure that you have the Android NDK installed - Android NDK r25c is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is `r25c1 required or the one tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recommended. I mention it to be consistent with Hansong's Android app demo.

I don't think there is a hard NDK requirement except for being after when Vulkan was added (I think r17). I tested with r19 and it was able to build too.

@@ -0,0 +1,192 @@
# ExecuTorch Vulkan Delegate

The ExecuTorch Vulkan delegate is a native GPU delegate for ExecuTorch that is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a session to describe the supported platform for both AOT and runtime?

@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in 414cd05.

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Apr 18, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 18, 2024
Summary:
Pull Request resolved: #3113

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: cccclai

Differential Revision: D56279743

Pulled By: SS-JIA

fbshipit-source-id: af55cdf2d8518c582b7d8deccb731c6bc442a1c9
(cherry picked from commit 414cd05)
@pytorchbot
Copy link
Collaborator

Cherry picking #3113

The cherry pick PR is at #3124

Details for Dev Infra team Raised by workflow job

@SS-JIA SS-JIA mentioned this pull request Apr 18, 2024
guangy10 pushed a commit that referenced this pull request Apr 18, 2024
Summary:
Pull Request resolved: #3113

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: cccclai

Differential Revision: D56279743

Pulled By: SS-JIA

fbshipit-source-id: af55cdf2d8518c582b7d8deccb731c6bc442a1c9
(cherry picked from commit 414cd05)

Co-authored-by: Sicheng Jia <[email protected]>
This was referenced Apr 25, 2024
@SS-JIA SS-JIA deleted the gh/SS-JIA/38/head branch January 24, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants