Update model arg name rope_theta to be consistent with those in llama's website #3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3147
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 09b644f with merge base 4ea0473 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mergennachin
approved these changes
Apr 19, 2024
|
@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Apr 19, 2024
|
@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…'s website (#3147) Summary: As title Reviewed By: larryliu0820 Differential Revision: D56357117 Pulled By: iseeyuan
facebook-github-bot
force-pushed
the
iseeyuan-patch-7
branch
from
c9c5878 to
09b644f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56357117 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title