Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented May 6, 2024

No description provided.

Copy link

pytorch-bot bot commented May 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3522

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit db6c854 with merge base f9db02a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2024
@lucylq lucylq force-pushed the lfq.size-test-ops-1 branch 2 times, most recently from 27d5b09 to d69bd8f Compare May 6, 2024 20:59
@facebook-github-bot
Copy link
Contributor

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lucylq lucylq marked this pull request as ready for review May 6, 2024 21:04
@lucylq lucylq requested review from mergennachin and swolchok May 6, 2024 23:17
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

lucylq added 2 commits May 8, 2024 10:36
Summary: Pull Request resolved: #3509

Reviewed By: mergennachin, swolchok

Differential Revision: D57003591

Pulled By: lucylq
Summary: Pull Request resolved: #3522

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

```
bash test/build_size_test.sh 

ExecuTorch with no ops binary size, unstripped:
-rwxr-xr-x 1 lfq users 68448 May  6 13:57 cmake-out/test/size_test
ExecuTorch with portable ops binary size, unstripped:
-rwxr-xr-x 1 lfq users 27129992 May  6 13:57 cmake-out/test/size_test_all_ops
```

Reviewed By: mergennachin

Differential Revision: D57017805

Pulled By: lucylq
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57017805

@facebook-github-bot
Copy link
Contributor

@lucylq merged this pull request in 8a5668a.

@lucylq lucylq deleted the lfq.size-test-ops-1 branch January 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants