Mac OSS CI use cmake built gtest #3713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3713
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2b1e39d with merge base d44877b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
May 23, 2024
|
seems that gtest package from conda polluted build |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huydhn
reviewed
May 24, 2024
huydhn
approved these changes
May 24, 2024
kirklandsign
force-pushed
the
oss-test-mac
branch
from
0f36c3b to
1da6537
Compare
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Instead of using buck. Note that for sccache shims, we need to create the tempdir outside of setup-macos.sh, to prevent from files removed after the script finishes.
kirklandsign
force-pushed
the
oss-test-mac
branch
from
1da6537 to
2b1e39d
Compare
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign merged this pull request in 5e9db9a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using buck. Note that for sccache shims, we need to create
the tempdir outside of setup-macos.sh, to prevent from files removed
after the script finishes.