Skip to content

Conversation

cymbalrush
Copy link
Contributor

Fixes two issues

  • Add model is now x + y earlier it used to be
int z = x + y;
z = z + x;
z = z + x;
z = z + z;
  • CoreML delegate was loading model manager at static initialization and there is a chance that executorch runtime might not have been initialized. ETCoreMLModelManagerDelegate loads it lazily, so that the runtime is guaranteed to be initialized.

Copy link

pytorch-bot bot commented Jun 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3876

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 308c715 with merge base 32335e5 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2024
@cymbalrush
Copy link
Contributor Author

@pytorchbot label ciflow/trunk

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mergennachin merged this pull request in 31b766b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants