add option to run mmlu with 5 shots #6146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6146
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 03b9346 with merge base df5b2ab ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This PR does the following changes:
- add `--num_fewshot` option which is required for running MMLU task with 5 shots
- set the default value of `--limit` to none such that we can actually run all examples
- update `eval_llama` to call `simple_evaluate` which is a wrapper of `evaluate` and does some extra work for us like getting the task dict
Test Plan:
- Make sure WikiText perplexity for llama 3.2 1B stays the same before and after the change.
Before, run eval_llama for llama 3.2 1B with limit set to None:
```
wikitext: {'word_perplexity,none': 12.78246428138387, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.610432252171856, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6874479705552373, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```
After, run eval_llama for llama 3.2 1B:
```
wikitext: {'word_perplexity,none': 12.78246428138387, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.610432252171856, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6874479705552373, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```
- Make sure that lm_eval(v0.4.2, which is used by eval_llama) and eval_llama reports similar number for llama 3.2 1B and 3B BF16 for MMLU task with 5 shots.
Example command for lm_eval:
```
lm_eval --model hf \
--model_args pretrained=meta-llama/Llama-3.2-1B-Instruct \
--tasks mmlu \
--device cuda \
-f 5 \
--batch_size auto
```
Example command for eval_llama:
```
python -m examples.models.llama2.eval_llama \
-c /home/lunwenh/models/1B_Instruct/consolidated.00.pth \
-p /home/lunwenh/models/1B_Instruct/params.json \
-t /home/lunwenh/models/1B_Instruct/tokenizer.model \
-kv \
-d bf16 \
--tasks mmlu \
-f 5 \
--max_seq_length 2048
```
Differential Revision: [D64215268](https://our.internmc.facebook.com/intern/diff/D64215268)
[ghstack-poisoned]
|
@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mergennachin
approved these changes
Oct 11, 2024
This PR does the following changes:
- add `--num_fewshot` option which is required for running MMLU task with 5 shots
- set the default value of `--limit` to none such that we can actually run all examples
- update `eval_llama` to call `simple_evaluate` which is a wrapper of `evaluate` and does some extra work for us like getting the task dict
Test Plan:
- Make sure WikiText perplexity for llama 3.2 1B stays the same before and after the change.
Before, run eval_llama for llama 3.2 1B with limit set to None:
```
wikitext: {'word_perplexity,none': 12.78246428138387, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.610432252171856, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6874479705552373, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```
After, run eval_llama for llama 3.2 1B:
```
wikitext: {'word_perplexity,none': 12.78246428138387, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.610432252171856, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6874479705552373, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```
- Make sure that lm_eval(v0.4.2, which is used by eval_llama) and eval_llama reports similar number for llama 3.2 1B and 3B BF16 for MMLU task with 5 shots.
Example command for lm_eval:
```
lm_eval --model hf \
--model_args pretrained=meta-llama/Llama-3.2-1B-Instruct \
--tasks mmlu \
--device cuda \
-f 5 \
--batch_size auto
```
Example command for eval_llama:
```
python -m examples.models.llama2.eval_llama \
-c /home/lunwenh/models/1B_Instruct/consolidated.00.pth \
-p /home/lunwenh/models/1B_Instruct/params.json \
-t /home/lunwenh/models/1B_Instruct/tokenizer.model \
-kv \
-d bf16 \
--tasks mmlu \
-f 5 \
--max_seq_length 2048
```
Differential Revision: [D64215268](https://our.internmc.facebook.com/intern/diff/D64215268)
[ghstack-poisoned]
|
@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This PR does the following changes:
- add `--num_fewshot` option which is required for running MMLU task with 5 shots
- set the default value of `--limit` to none such that we can actually run all examples
- update `eval_llama` to call `simple_evaluate` which is a wrapper of `evaluate` and does some extra work for us like getting the task dict
Test Plan:
- Make sure WikiText perplexity for llama 3.2 1B stays the same before and after the change.
Before, run eval_llama for llama 3.2 1B with limit set to None:
```
wikitext: {'word_perplexity,none': 12.78246428138387, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.610432252171856, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6874479705552373, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```
After, run eval_llama for llama 3.2 1B:
```
wikitext: {'word_perplexity,none': 12.78246428138387, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.610432252171856, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6874479705552373, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```
- Make sure that lm_eval(v0.4.2, which is used by eval_llama) and eval_llama reports similar number for llama 3.2 1B and 3B BF16 for MMLU task with 5 shots.
Example command for lm_eval:
```
lm_eval --model hf \
--model_args pretrained=meta-llama/Llama-3.2-1B-Instruct \
--tasks mmlu \
--device cuda \
-f 5 \
--batch_size auto
```
Example command for eval_llama:
```
python -m examples.models.llama2.eval_llama \
-c /home/lunwenh/models/1B_Instruct/consolidated.00.pth \
-p /home/lunwenh/models/1B_Instruct/params.json \
-t /home/lunwenh/models/1B_Instruct/tokenizer.model \
-kv \
-d bf16 \
--tasks mmlu \
-f 5 \
--max_seq_length 2048
```
Differential Revision: [D64215268](https://our.internmc.facebook.com/intern/diff/D64215268)
[ghstack-poisoned]
|
@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@helunwencser merged this pull request in e95aa9d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR does the following changes:
--num_fewshotoption which is required for running MMLU task with 5 shots--limitto none such that we can actually run all exampleseval_llamato callsimple_evaluatewhich is a wrapper ofevaluateand does some extra work for us like getting the task dictTest Plan:
Before, run eval_llama for llama 3.2 1B with limit set to None:
After, run eval_llama for llama 3.2 1B:
Example command for lm_eval:
Example command for eval_llama:
Differential Revision: D64215268