fixed empty output from runtime executor in CPU flow #6184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6184
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 96a064d with merge base 5512fe0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64272605 |
Vysarat
approved these changes
Oct 11, 2024
| @@ -52,6 +52,7 @@ set(_aten_ops__srcs | |||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_expand_copy.cpp" | |||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_gelu.cpp" | |||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_empty.cpp" | |||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/util/dtype_util.cpp" | |||
There was a problem hiding this comment.
maybe move it up with the other utils?
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| from executorch.backends.cadence.aot.compiler import ( | |||
| convert_pt2, | |||
| export_to_cadence, | |||
| export_to_cadence_edge_executorch, | |||
There was a problem hiding this comment.
is that API new? I don't see it in the changes
There was a problem hiding this comment.
good catch. now ported.
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Oct 11, 2024
Summary: - add missing dependency dtype_util.cpp - it was missing etrecord. And dump-output is not toggled in executor. - Also enable runtime logging Reviewed By: Vysarat Differential Revision: D64272605
zonglinpeng
force-pushed
the
export-D64272605
branch
from
994c92f to
22e57fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64272605 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Oct 11, 2024
Summary: - add missing dependency dtype_util.cpp - it was missing etrecord. And dump-output is not toggled in executor. - Also enable runtime logging Reviewed By: Vysarat Differential Revision: D64272605
zonglinpeng
force-pushed
the
export-D64272605
branch
from
22e57fe to
14efbf6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64272605 |
mcremon-meta
approved these changes
Oct 11, 2024
| @@ -197,11 +204,12 @@ def export_to_edge( | |||
| # Export the model and lower it to an EdgeProgramManager (in edge IR), and | |||
| # apply passes specific to Cadence DSP execution. Return both to print the | |||
| # differences. | |||
| def export_to_cadence( | |||
| def export_to_cadence_edge_executorch( | |||
Summary: - add missing dependency dtype_util.cpp - it was missing etrecord. And dump-output is not toggled in executor. - Also enable runtime logging Reviewed By: Vysarat, mcremon-meta Differential Revision: D64272605
zonglinpeng
force-pushed
the
export-D64272605
branch
from
14efbf6 to
96a064d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64272605 |
|
This pull request has been merged in cd2d2b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D64272605