Skip to content

Enable kwarg inputs for pt2e quantize #7436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Enable kwarg inputs for pt2e quantize #7436

merged 1 commit into from
Feb 27, 2025

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Dec 24, 2024 •
edited
Loading

Summary

For quantizing models that have kwarg forward() inputs, such as TorchTune Llama models

Test plan

N/A

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7436

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 4655850 with merge base 4b85ee2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2024
@jackzhxng jackzhxng changed the title Enable kwarg inputs for pt2e quantize for torchtune models Enable kwarg inputs for pt2e quantize Dec 24, 2024
@jackzhxng jackzhxng added the release notes: quantization Changes to quantization label Jan 2, 2025
@jackzhxng jackzhxng requested a review from tarun292 January 9, 2025 21:35
@cccclai cccclai added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 7, 2025
@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng @facebook-github-bot
Enable kwarg inputs for pt2e quantize (#7436)
4655850 
Summary:
For quantizing models that have kwarg forward() inputs, such as TorchTune Llama models


Test Plan: N/A

Reviewed By: tarun292

Differential Revision: D70206003

Pulled By: jackzhxng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70206003

@facebook-github-bot facebook-github-bot merged commit 316099f into main Feb 27, 2025
51 of 52 checks passed
@facebook-github-bot facebook-github-bot deleted the jz/quantize_kwargs branch February 27, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

+1 more reviewer

@tarun292 tarun292 tarun292 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: quantization Changes to quantization triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackzhxng @facebook-github-bot @mergennachin @tarun292 @cccclai