Skip to content

Allow querying all backends registered with the executorch runtime #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omerjerk
Copy link

Summary: Partially resolves: #8267

Differential Revision: D69754074

Summary: Partially resolves: pytorch#8267

Differential Revision: D69754074
Copy link

pytorch-bot bot commented Feb 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8521

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 53b5289 with merge base 5e4d6b6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69754074

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok
Copy link
Contributor

Adding reviewers in the top-right corner of this PR page will help get your PR looked at.

std::vector cannot be used in runtime/backend; it is part of ExecuTorch core. See https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#cc-standard-library-usage . (We should update that document to clarify what is in ExecuTorch core and what is not...)

Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for std::vector. see top-level comment on PR. not sure offhand how to get this done without heap allocation but I imagine there are other examples of "enumeration functions" as mentioned in the issue. I would recommend just checking with issue owner @GregoryComer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API to query backend availability at runtime
3 participants