Skip to content

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Feb 27, 2025

This is not needed anymore after Vela bump.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

This is not needed anymore after Vela bump.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Iedfc7ce0e1821afe0aed713494def16afe5a1183
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Feb 27, 2025
Copy link

pytorch-bot bot commented Feb 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8765

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs, 1 Pending, 1 Unrelated Failure

As of commit 8f948d2 with merge base 30d4cc8 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
@zingo
Copy link
Collaborator

zingo commented Feb 27, 2025

Failed MacOS tests are unrelated

@zingo zingo merged commit 8348ec0 into pytorch:main Feb 27, 2025
115 of 121 checks passed
Comment on lines -29 to 32
def dim_check(shape=torch.Size) -> bool:
check = shape[0] == 1
for dim in shape:
check = True
for dim in shape[1:]:
check &= 1 <= dim <= 65536
return check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI this function could be written more idiomatically as return all([1 <= dim <= 65536 for dim in shape[1:]])

@Erik-Lundell Erik-Lundell deleted the remove-constraint branch July 31, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants