Skip to content

[Windows] [Tensor.cpp] add #include <algorithm> #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

[Windows] [Tensor.cpp] add #include <algorithm> #8912

merged 1 commit into from
Mar 4, 2025

Conversation

SamGondelman
Copy link
Contributor

Summary

There are a number of parallel in progress/stale pushes for Windows support. This is the first PR in my attempt, which I will be breaking into small, disparate PRs. I found this necessary for stable_sort and iter_swap in this file.

Test plan

No functional change, verify everything builds.

@SamGondelman SamGondelman requested a review from SS-JIA as a code owner March 4, 2025 01:55
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8912

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d2afa5 with merge base 24671a9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@SS-JIA SS-JIA added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 4, 2025
@SS-JIA SS-JIA merged commit d897e73 into pytorch:main Mar 4, 2025
50 of 52 checks passed
@SamGondelman SamGondelman deleted the windows-algorithm-include branch March 4, 2025 19:34
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
@SamGondelman
[Windows] [Tensor.cpp] add #include <algorithm> (#8912)
2a11642 
[Tensor.cpp] add algorithm include to get stable_sort and iter_swap on windows
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
@GregoryComer GregoryComer mentioned this pull request Aug 28, 2025
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamGondelman @SS-JIA @facebook-github-bot