Skip to content

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Mar 10, 2025

Fix the lint runner error from #8857

Copy link

pytorch-bot bot commented Mar 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9076

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0100bb5 with merge base 51901f3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2025
@kirklandsign kirklandsign self-assigned this Mar 10, 2025
@kirklandsign kirklandsign removed their assignment Mar 10, 2025
Copy link
Contributor

@zonglinpeng zonglinpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good to know the trick! Thought "advice" wouldnt break global lint. Thank you for the fix

Comment on lines +811 to +813
def _remove_unused_cat( # noqa: C901
self, graph_module: torch.fx.GraphModule
) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good if we can actually reduce the complexity of this function

@jathu jathu merged commit 545e6a2 into pytorch:main Mar 10, 2025
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants