use numel() when appropriate in get_reduced_dim_product #9142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2025
JacobSzwejbka
approved these changes
Mar 11, 2025
JacobSzwejbka
approved these changes
Mar 11, 2025
| if (in.dim() == 0) { | ||
| return 1; | ||
| } | ||
| size_t dim_product = 1; |
There was a problem hiding this comment.
linter wants this gone
mcr229
approved these changes
Mar 11, 2025
manuelcandales
approved these changes
Mar 12, 2025
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
No need to re-calculate numel() here. ghstack-source-id: 54478b9 ghstack-comment-id: 2715051327 Pull Request resolved: pytorch/executorch#9142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to re-calculate numel() here.