Fix benchmark job and apple demo app job #9329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
jackzhxng,
iseeyuan,
swolchok,
tarun292,
lucylq,
shoumikhin and
kirklandsign
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9329
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit 903cf63 with merge base 84911fb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
nothing obviously wrong to me, but leaving for @shoumikhin or somebody else with specific context. don't know about the new .cpp file |
shoumikhin
reviewed
Mar 17, 2025
Oops that's a mistake |
shoumikhin
reviewed
Mar 17, 2025
shoumikhin
approved these changes
Mar 17, 2025
digantdesai
approved these changes
Mar 18, 2025
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
### Summary Fixes CI failures caused by pytorch#9114 We need to tell xcode project about the new tokenizers repo and include path. ### Test plan These jobs need to pass: ``` Apple / build-benchmark-app / macos-job Apple / build-demo-ios / macos-job ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failures caused by #9114
We need to tell xcode project about the new tokenizers repo and include path.
Test plan
These jobs need to pass: