Skip to content

Revert "Arm backend: use dbg_fail when node visitors raise exceptions" #9376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Revert "Arm backend: use dbg_fail when node visitors raise exceptions" #9376

merged 1 commit into from
Mar 18, 2025

Conversation

larryliu0820
Copy link
Contributor

Reverts #9268

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9376

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit 1e98d08 with merge base f86d7e3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
@larryliu0820 larryliu0820 requested review from oscarandersson8218, per and kirklandsign and removed request for digantdesai and oscarandersson8218 March 18, 2025 21:33
@larryliu0820 larryliu0820 merged commit a7ef013 into main Mar 18, 2025
79 of 82 checks passed
@larryliu0820 larryliu0820 deleted the revert-9268-dbg_fail branch March 18, 2025 22:41
@per
Copy link
Collaborator

per commented Mar 19, 2025

Any more information on why this was reverted?

oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
@larryliu0820 @oscarandersson8218
Revert "Arm backend: use dbg_fail when node visitors raise exceptions" (
4dfd33b 
pytorch#9376)

Reverts pytorch#9268
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
@larryliu0820 @DannyYuyang-quic
Revert "Arm backend: use dbg_fail when node visitors raise exceptions" (
411d6c8 
pytorch#9376)

Reverts pytorch#9268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@per per Awaiting requested review from per

@oscarandersson8218 oscarandersson8218 Awaiting requested review from oscarandersson8218

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larryliu0820 @per @kirklandsign @facebook-github-bot