Implement unary_ufunc functions using elementwise_util #9386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9386
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 6 Pending, 1 Unrelated FailureAs of commit d14a503 with merge base 2dedc9e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 19, 2025
Merged
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 19, 2025
This was referenced Mar 20, 2025
swolchok
commented
May 28, 2025
Comment on lines
+148
to
+151
| ScalarType compute_type = in.scalar_type() == ScalarType::Double | ||
| ? ScalarType::Double | ||
| : ScalarType::Float; | ||
| ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&] { |
There was a problem hiding this comment.
this is the only ET_SWITCH change remaining -- we are switching over the possible compute types, not the input/output types.
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
manuelcandales
approved these changes
May 30, 2025
|
tests looking good; few stragglers but it's only llava and then one each of qnn/arm which shouldn't be affected |
JacobSzwejbka
added a commit
that referenced
this pull request
Jun 10, 2025
This reverts commit dffbd42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util).