Arm Backend: temp fix for flaky eq op test #9794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add eq_scalar_rank4_randn test to xfail temporarily, and set strict to false - Change misleading aten_op naming Signed-off-by: Fang-Ching <[email protected]> Change-Id: I2356b013c1a7a50d3451585cfe03687f16e6a358
fumchin
added
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9794
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 PendingAs of commit 76f8003 with merge base bad2fa9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily addresses a flaky eq operator test for the ARM backend.
- Renames misleading operation names from aten_op_BI and aten_op_MI to aten_op_Tensor and aten_op_Scalar respectively.
- Adds an xfail entry for the eq_scalar_rank4_randn test with a clear bug reference and sets strict mode to false to ease test flakiness.
Comments suppressed due to low confidence (2)
backends/arm/test/ops/test_eq.py:144
- [nitpick] The function name test_eq_u85_BI still reflects the old naming convention (BI), even though it now uses aten_op_Tensor. Consider renaming the function (e.g., to test_eq_u85_Tensor) for consistency.
def test_eq_u85_BI(test_module):
backends/arm/test/ops/test_eq.py:141
- Since strict=False is a temporary workaround for the flaky test, consider adding a comment that references the bug ID (MLETORCH-847) or notes that the workaround should be revisited in the future.
strict=False,
zingo
approved these changes
Apr 1, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
This patch provides a temporary workaround for the flaky op_eq test. - Add eq_scalar_rank4_randn test to xfail temporarily, and set strict to false - Change misleading aten_op naming Signed-off-by: Fang-Ching <[email protected]>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides a temporary workaround for the flaky op_eq test.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218