Arm backend: Convert assert to throw TypeError in arm_pass_utils #9866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_node_debug_info() without graph_module will now only print the node information. Change-Id: I12d9cc30eafc9c1fadfb50dccaf39fc3b4b5663b Signed-off-by: Sebastian Larsson <[email protected]>
There's a risk with using asserts in production code as it might get optimized out. TypeError is more explicit and conveys more information abour what has gone wrong. Change-Id: I2c811f9290e6beefd9a4a99d83ec9220209a56a8 Signed-off-by: Sebastian Larsson <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9866
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4ac0014 with merge base 3600d4f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sebastian-Larsson
added
partner: arm
|
CI failure seems unrelated. Started happening after this was merged: #9643 |
zingo
approved these changes
Apr 3, 2025
zingo
approved these changes
Apr 3, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Part of an effort to move towards using try/except instead of asserts to have better debugging capabilities and traceability in the Arm backend. Signed-off-by: Sebastian Larsson <[email protected]>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of an effort to move towards using try/except instead of asserts to have better debugging capabilities and traceability in the Arm backend.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218