Arm backend: Convert assert to raise ValueError in op_clamp #9932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asserts are converted to proper raises to ensure graph integrity. It should not be possible for clamp to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly. Change-Id: Ibb55f3987c027251c515ab0371d34b79ecb886c0 Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9932
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit e8ff4ba with merge base 91a14f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Apr 11, 2025
|
huggingface problems are unrelated, retriggered the test. |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Asserts are converted to proper raises to ensure graph integrity. It should not be possible for clamp to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly. Signed-off-by: Sebastian Larsson <[email protected]>
This was referenced Apr 14, 2025
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
…9932) Asserts are converted to proper raises to ensure graph integrity. It should not be possible for clamp to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly. Signed-off-by: Sebastian Larsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts are converted to proper raises to ensure graph integrity.
It should not be possible for clamp to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218