Change training pybind extension_module linkage to static #9961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes #9576. Use `extension_module_static` in building `_training_lib`. Test Plan: Rely on unit test, also did a manual install in editable mode: ```bash ./install_executorch.sh --pybind training -e python -c "from executorch.extension.training.pybindings._training_lib import get_sgd_optimizer" ``` Reviewers: Subscribers: Tasks: Tags: (cherry picked from commit d0bf832)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9961
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 1d6778e with merge base 771588a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@larryliu0820 there are some failing tests, including segfault in lava runner. Can you have a look? |
Actually, it looks like it predates this PR |
metascroy
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes #9576. Use
extension_module_staticin building_training_lib.Test Plan: Rely on unit test, also did a manual install in editable mode:
./install_executorch.sh --pybind training -e python -c "from executorch.extension.training.pybindings._training_lib import get_sgd_optimizer"Reviewers:
Subscribers:
Tasks:
Tags: