This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Added im2col batch rule and enabled vmap for nn.functional.unfold op #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Added im2col batch rule and enabled vmap for nn.functional.unfold op - Updated tests Using EXISTING_BDIM macro to put bdim into 0 as im2col expects dim=0 to be batch dim Related to pytorch#240
16 tasks
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Jul 20, 2022
…l.unfold op (pytorch/functorch#262) Description: - Added im2col batch rule and enabled vmap for nn.functional.unfold op - Updated tests Using EXISTING_BDIM macro to put bdim into 0 as im2col expects dim=0 to be batch dim Related to pytorch/functorch#240
bigfootjon
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 21, 2022
…l.unfold op (pytorch/functorch#262) Description: - Added im2col batch rule and enabled vmap for nn.functional.unfold op - Updated tests Using EXISTING_BDIM macro to put bdim into 0 as im2col expects dim=0 to be batch dim Related to pytorch/functorch#240
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using
EXISTING_BDIMmacro to put bdim into 0 as im2col expects dim=0 to be the batch dimRelated to #240
Additionally moved
OP_DECOMPOSE(nll_loss*)into alphabetical order.