[batch-rule] householder_product #322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
commented
Dec 8, 2021
| @@ -160,6 +178,7 @@ TORCH_LIBRARY_IMPL(aten, FT_BATCHED_KEY, m) { | |||
| VMAP_SUPPORT("mv", mv_batch_rule); | |||
| VMAP_SUPPORT("mm", mm_batch_rule); | |||
| m.impl("linear", linear_decomp); | |||
| m.impl("orgqr", orgqr_decomp); | |||
There was a problem hiding this comment.
Without this we get
RuntimeError: aten::orgqr hit the vmap fallback which is currently disabled
But orgqr is a composite operator 🤔.
There was a problem hiding this comment.
Maybe, you can add it into BatchRulesDecompositions.cpp
Chillee
reviewed
Dec 8, 2021
| @@ -151,6 +151,20 @@ Tensor linear_decomp( | |||
| return result; | |||
| } | |||
|
|
|||
| std::tuple<Tensor, c10::optional<int64_t>> | |||
There was a problem hiding this comment.
Can we use EXISTING_BDIM or EXISTING_BDIM_ALL_BOXED for this?
There was a problem hiding this comment.
Unfortunately neither of them works.
EXISTING_BDIMseems to assume that onlyselfhas bdim- With
EXISTING_BDIM_ALL_BOXEDwe gettorch.linalg.householder_product: input.shape[-1] must be greater than or equal to tau.shape[-1]
16 tasks
|
@Chillee @kshitij12345 can we merge this? |
|
@zou3519 I'm fine with merging it. |
zou3519
added a commit
that referenced
this pull request
Jul 18, 2022
Original code written by @kshitij12345 in #322, this PR is just a rebase onto main
zou3519
added a commit
that referenced
this pull request
Jul 18, 2022
Original code written by @kshitij12345 in #322, this PR is just a rebase onto main
|
Merged in #972 |
zou3519
added a commit
to zou3519/pytorch
that referenced
this pull request
Jul 20, 2022
Original code written by @kshitij12345 in pytorch/functorch#322, this PR is just a rebase onto main
bigfootjon
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 21, 2022
Original code written by @kshitij12345 in pytorch/functorch#322, this PR is just a rebase onto main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #240