Skip to content

[runtime] Pass Input Output Placeholder labels #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gcatron opened this issue Nov 2, 2018 · 2 comments · Fixed by #2674
Closed

[runtime] Pass Input Output Placeholder labels #1953

gcatron opened this issue Nov 2, 2018 · 2 comments · Fixed by #2674
Assignees

Comments

@gcatron
Copy link
Contributor

gcatron commented Nov 2, 2018

From the Context it's not easy to efficiently identify whether a placeholder is an input or output. This means all placeholders may be copied to and from the device. It would be good to pass this information to runtime to make device loading/unloading more efficient.

@rdzhabarov
Copy link
Contributor

it's not fixed

@bertmaher
Copy link
Contributor

Oh hey this is interesting and I hadn't noticed that it was referenced on my PR #2160. I don't think that PR was the right solution though. From the perspective of the runtime, I think we probably care about WeightVars more than Placeholders (does that seem correct?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants