-
Notifications
You must be signed in to change notification settings - Fork 699
Update createBundle to set symbol input and output #2674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update createBundle to set symbol input and output #2674
Conversation
30913db
to
9a4ee52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also consider trainable Placeholders. I think this code will mark them as both inputs and outputs. Is that desired? If so, let's add a unit test for that too.
Consider the two scenarios: 1. We have a bug in this code that the unit test catches. 2. We need to change the design of the function to make PH an argument list. Is this unit test carrying its weight? It will make it difficult for us to change the design of the compiler and at the same time won’t provide much safety. Maybe we can update an existing test instead of adding a new test that we will need to update later? |
9a4ee52
to
d9c1e13
Compare
There is a bug here. Save nodes accept placeholders as inputs. If this is a save node you need to check if this is the destination. |
9f83509
to
745e8e6
Compare
f5c6851
to
daba9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few small nits.
Also wondering if it would be a good idea to add a QuantizationProfileNode
to the test, so that you also check that a Placeholder that's not an output via a SaveNode
is still marked as output, and that it's also marked as both input and output.
0ae19de
to
6ed2150
Compare
Nice! |
6ed2150
to
6117878
Compare
Description: This updates the create method on RuntimeBundle to properly set input and output status for symbols.
Testing: ninja test:
Documentation:
Fixes #1953