[cmake][test] Add a add_glow_test function and 'check' target #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This is a proof-of-concept of how we could solve issue [https://github.com//issues/1086]. Let me know if I should carry on. In particular, if we decide to use this check target, I would probably need to update the read me. |
nadavrot
approved these changes
Jun 5, 2018
jfix71
approved these changes
Jun 5, 2018
CMakeLists.txt
Outdated
| @@ -75,3 +76,9 @@ add_subdirectory(tests) | |||
| add_custom_target(dependency_graph | |||
| "${CMAKE_COMMAND}" "--graphviz=dependency_graph" . | |||
| WORKING_DIRECTORY "${CMAKE_BINARY_DIR}") | |||
|
|
|||
| # Fecth the dependencies for all the tests. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
tests/unittests/CMakeLists.txt
Outdated
| @@ -67,7 +67,7 @@ target_link_libraries(MLTest | |||
| ExecutionEngine | |||
| gtest | |||
| testMain) | |||
| add_test(MLTest ${GLOW_BINARY_DIR}/tests/MLTest) | |||
| add_glow_test(MLTest COMMAND ${GLOW_BINARY_DIR}/tests/MLTest) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Introduce the add_glow_test function that on top of adding the test to the list of tests to be run with ctest, it will register the dependencies on the actual executable. Thanks to this information, the new 'check' target can re-build the test executables if needed and then run the test. In other words, the combination of those two additions act like `ninja all && ninja test`, except we don't have to think about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the add_glow_test function that on top of adding the test
to the list of tests to be run with ctest, it will register the
dependencies on the actual executable.
Thanks to this information, the new 'check' target can re-build
the test executables if needed and then run the test.
In other words, the combination of those two additions act like
ninja all && ninja test, except we don't have to think about it.