Skip to content

Start sketching out the optimizer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Start sketching out the optimizer #12

wants to merge 7 commits into from

Conversation

nadavrot
Copy link
Contributor

Start to sketch out the optimizer.

This commit adds a very simple optimizer library that contains a single method
optimize(). This method drives the whole optimization pipeline, which is
currently very basic. The next step would be to add this into the compilation
pipeline and run it on all of our tests.

@nadavrot
Change the llvm tag from hash to label
ea5280b
@nadavrot
Start to sketch out the optimizer.
43f6edb 
This commit adds a very simple optimizer library that contains a single method
optimize(). This method drives the whole optimization pipeline, which is
currently very basic. The next step would be to add this into the compilation
pipeline and run it on all of our tests.
@nadavrot nadavrot requested a review from compnerd September 30, 2017 00:57
@nadavrot nadavrot requested review from zem7 and jspark1105 September 30, 2017 00:57
compnerd
compnerd suggested changes Sep 30, 2017
View reviewed changes
src/glow/Optimizer/CMakeLists.txt Outdated

add_library(Optimizer
Optimizer.cpp
)

This comment was marked as off-topic.

Sign in to view

src/glow/Optimizer/CMakeLists.txt Outdated
)
target_link_libraries(Optimizer
PRIVATE
IR

This comment was marked as off-topic.

Sign in to view

src/glow/Optimizer/Optimizer.cpp Outdated
/// Hoists Dealloc instructions right after their last use.
static void hoistDealloc(Module &M) {
using iterator = Module::InstListTy::iterator;
/// Maps activation instructions to their last non-dealloc user.

This comment was marked as off-topic.

Sign in to view

src/glow/Optimizer/Optimizer.cpp Outdated
using iterator = Module::InstListTy::iterator;
/// Maps activation instructions to their last non-dealloc user.
std::unordered_map<AllocActivationInst *, iterator> lastUser;
auto &bb = M.getInstrs();

This comment was marked as off-topic.

Sign in to view

src/glow/Optimizer/Optimizer.cpp Outdated
auto &bb = M.getInstrs();

// Record the last use of each dealloc.
for (auto it = bb.begin(), e = bb.end(); it != e; ++it) {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

src/glow/Optimizer/Optimizer.cpp Outdated
auto *alloc = cast<AllocActivationInst>(da->getOperand(0).first);

it = bb.erase(curr);
auto where = lastUser[alloc];

This comment was marked as off-topic.

Sign in to view

@nadavrot
Change the llvm tag from hash to label
93ce254
@nadavrot
Start to sketch out the optimizer.
c13c463 
This commit adds a very simple optimizer library that contains a single method
optimize(). This method drives the whole optimization pipeline, which is
currently very basic. The next step would be to add this into the compilation
pipeline and run it on all of our tests.
@nadavrot
Merge branch 'sketch_optimizer' of github.com:nadavrot/Glow into sket…
9536bbf 
…ch_optimizer
@nadavrot
Start to sketch out the optimizer.
2c29546 
This commit adds a very simple optimizer library that contains a single method
optimize(). This method drives the whole optimization pipeline, which is
currently very basic. The next step would be to add this into the compilation
pipeline and run it on all of our tests.
@nadavrot
Merge branch 'sketch_optimizer' of github.com:nadavrot/Glow into sket…
e763f3c 
…ch_optimizer
@nadavrot
Copy link
Contributor Author

I fixed all of the comments in this pull request, but in the process I totally killed it. Not sure why it says that I have 7 commits. I'll close this one and create another pull request.

@nadavrot nadavrot closed this Sep 30, 2017
@nadavrot nadavrot deleted the sketch_optimizer branch September 30, 2017 04:29
@HKLee2040 HKLee2040 mentioned this pull request Sep 18, 2018
Closed
facebook-github-bot pushed a commit that referenced this pull request Jun 15, 2019
@facebook-github-bot
Fix bugs in BatchedReduceAddInst implementation (#3118)
6609788 
Summary:
**Description**
This commit fixes two bugs in the OpenCL implementation of
`BatchedReduceAddInst` and adds a few comments for clarity.

The first is a segmentation fault caused by
incorporating feedback on #2958. A suggestion was made to make the loop
variable `i` in the loop that computes `batchSliceSizes` count down instead of
count up, but this suggestion was taken without changing the type (which was `size_t`,
an unsigned type), so the loop never terminates and eventually leads to a
segmentation fault.

The second bug is an incorrect computation of `destSliceSizes`. Instead of
multiplying the slice size at a dimension with the number of elements in
that same dimension, the code was multiplying the former with the number
of elements in the *adjacent* dimension. This was surfaced by the unit
test added in #2958 for `axis = 2`.

**Test Plan**
1) `ninja check` with OpenCL enabled, DEBUG mode

```
      Start  1: BackendCorrectnessTest
 1/34 Test  #1: BackendCorrectnessTest ..............   Passed   21.28 sec
      Start  2: BackendTest
 2/34 Test  #2: BackendTest .........................   Passed    1.97 sec
      Start  3: BasicIRTest
 3/34 Test  #3: BasicIRTest .........................   Passed    0.05 sec
      Start  4: Caffe2ImporterTest
 4/34 Test  #4: Caffe2ImporterTest ..................   Passed    3.00 sec
      Start  5: DeviceManagerTest
 5/34 Test  #5: DeviceManagerTest ...................   Passed    0.76 sec
      Start  6: ThreadPoolExecutorTest
 6/34 Test  #6: ThreadPoolExecutorTest ..............   Passed    1.48 sec
      Start  7: Float16Test
 7/34 Test  #7: Float16Test .........................   Passed    0.01 sec
      Start  8: GemmTest
 8/34 Test  #8: GemmTest ............................   Passed    0.05 sec
      Start  9: GlowOnnxifiManagerTest
 9/34 Test  #9: GlowOnnxifiManagerTest ..............   Passed    0.06 sec
      Start 10: GradCheckTest
10/34 Test #10: GradCheckTest .......................   Passed    4.72 sec
      Start 11: GraphGradTest
11/34 Test #11: GraphGradTest .......................   Passed    0.06 sec
      Start 12: GraphOptzTest
12/34 Test #12: GraphOptzTest .......................   Passed    0.03 sec
      Start 13: GraphSchedulerTest
13/34 Test #13: GraphSchedulerTest ..................   Passed    0.01 sec
      Start 14: GraphTest
14/34 Test #14: GraphTest ...........................   Passed    1.03 sec
      Start 15: HostManagerTest
15/34 Test #15: HostManagerTest .....................   Passed    7.49 sec
      Start 16: HyphenTest
16/34 Test #16: HyphenTest ..........................   Passed    1.17 sec
      Start 17: IROptTest
17/34 Test #17: IROptTest ...........................   Passed    0.01 sec
      Start 18: ImageTest
18/34 Test #18: ImageTest ...........................   Passed    0.31 sec
      Start 19: LLVMIRGenTest
19/34 Test #19: LLVMIRGenTest .......................   Passed    0.01 sec
      Start 20: MLTest
20/34 Test #20: MLTest ..............................   Passed   46.30 sec
      Start 21: MemoryAllocatorTest
21/34 Test #21: MemoryAllocatorTest .................   Passed    0.03 sec
      Start 22: OCLTest
22/34 Test #22: OCLTest .............................   Passed    0.24 sec
      Start 23: OnnxImporterTest
23/34 Test #23: OnnxImporterTest ....................   Passed    0.12 sec
      Start 24: OperatorGradTest
24/34 Test #24: OperatorGradTest ....................   Passed    0.05 sec
      Start 25: OperatorTest
25/34 Test #25: OperatorTest ........................   Passed   14.47 sec
      Start 26: PartitionerTest
26/34 Test #26: PartitionerTest .....................   Passed    0.05 sec
      Start 28: ProvisionerTest
27/34 Test #28: ProvisionerTest .....................   Passed    1.00 sec
      Start 29: QuantizationTest
28/34 Test #29: QuantizationTest ....................   Passed    7.46 sec
      Start 30: TensorsTest
29/34 Test #30: TensorsTest .........................   Passed    0.36 sec
      Start 31: TensorPoolTest
30/34 Test #31: TensorPoolTest ......................   Passed    0.01 sec
      Start 32: ThreadPoolTest
31/34 Test #32: ThreadPoolTest ......................   Passed    0.01 sec
      Start 33: TraceEventsTest
32/34 Test #33: TraceEventsTest .....................   Passed   10.62 sec
      Start 34: TypeAToTypeBFunctionConverterTest
33/34 Test #34: TypeAToTypeBFunctionConverterTest ...   Passed    0.06 sec
      Start 35: UtilsTest
34/34 Test #35: UtilsTest ...........................   Passed    0.02 sec

100% tests passed, 0 tests failed out of 34

Total Test time (real) = 124.33 sec
```

2) `ninja check` with OpenCL enabled, RELEASE mode
```
      Start  1: BackendCorrectnessTest
 1/34 Test  #1: BackendCorrectnessTest ..............   Passed   11.51 sec
      Start  2: BackendTest
 2/34 Test  #2: BackendTest .........................   Passed    1.53 sec
      Start  3: BasicIRTest
 3/34 Test  #3: BasicIRTest .........................   Passed    0.02 sec
      Start  4: Caffe2ImporterTest
 4/34 Test  #4: Caffe2ImporterTest ..................   Passed    0.62 sec
      Start  5: DeviceManagerTest
 5/34 Test  #5: DeviceManagerTest ...................   Passed    0.83 sec
      Start  6: ThreadPoolExecutorTest
 6/34 Test  #6: ThreadPoolExecutorTest ..............   Passed    0.71 sec
      Start  7: Float16Test
 7/34 Test  #7: Float16Test .........................   Passed    0.01 sec
      Start  8: GemmTest
 8/34 Test  #8: GemmTest ............................   Passed    0.31 sec
      Start  9: GlowOnnxifiManagerTest
 9/34 Test  #9: GlowOnnxifiManagerTest ..............   Passed    0.33 sec
      Start 10: GradCheckTest
10/34 Test #10: GradCheckTest .......................   Passed    1.90 sec
      Start 11: GraphGradTest
11/34 Test #11: GraphGradTest .......................   Passed    0.32 sec
      Start 12: GraphOptzTest
12/34 Test #12: GraphOptzTest .......................   Passed    0.03 sec
      Start 13: GraphSchedulerTest
13/34 Test #13: GraphSchedulerTest ..................   Passed    0.02 sec
      Start 14: GraphTest
14/34 Test #14: GraphTest ...........................   Passed    0.59 sec
      Start 15: HostManagerTest
15/34 Test #15: HostManagerTest .....................   Passed   10.61 sec
      Start 16: HyphenTest
16/34 Test #16: HyphenTest ..........................   Passed    4.18 sec
      Start 17: IROptTest
17/34 Test #17: IROptTest ...........................   Passed    0.04 sec
      Start 18: ImageTest
18/34 Test #18: ImageTest ...........................   Passed    0.10 sec
      Start 19: LLVMIRGenTest
19/34 Test #19: LLVMIRGenTest .......................   Passed    0.71 sec
      Start 20: MLTest
20/34 Test #20: MLTest ..............................   Passed   52.44 sec
      Start 21: MemoryAllocatorTest
21/34 Test #21: MemoryAllocatorTest .................   Passed    0.03 sec
      Start 22: OCLTest
22/34 Test #22: OCLTest .............................   Passed    0.96 sec
      Start 23: OnnxImporterTest
23/34 Test #23: OnnxImporterTest ....................   Passed    0.89 sec
      Start 24: OperatorGradTest
24/34 Test #24: OperatorGradTest ....................   Passed    0.76 sec
      Start 25: OperatorTest
25/34 Test #25: OperatorTest ........................   Passed   33.00 sec
      Start 26: PartitionerTest
26/34 Test #26: PartitionerTest .....................   Passed    0.79 sec
      Start 28: ProvisionerTest
27/34 Test #28: ProvisionerTest .....................   Passed    3.00 sec
      Start 29: QuantizationTest
28/34 Test #29: QuantizationTest ....................   Passed   19.64 sec
      Start 30: TensorsTest
29/34 Test #30: TensorsTest .........................   Passed    0.09 sec
      Start 31: TensorPoolTest
30/34 Test #31: TensorPoolTest ......................   Passed    0.04 sec
      Start 32: ThreadPoolTest
31/34 Test #32: ThreadPoolTest ......................   Passed    0.04 sec
      Start 33: TraceEventsTest
32/34 Test #33: TraceEventsTest .....................   Passed   13.18 sec
      Start 34: TypeAToTypeBFunctionConverterTest
33/34 Test #34: TypeAToTypeBFunctionConverterTest ...   Passed    0.87 sec
      Start 35: UtilsTest
34/34 Test #35: UtilsTest ...........................   Passed    0.04 sec

100% tests passed, 0 tests failed out of 34

Total Test time (real) = 160.15 sec
```
3) `ninja check` with OpenCL enabled, ASAN+UBSAN mode
```
      Start  1: BackendCorrectnessTest
 1/34 Test  #1: BackendCorrectnessTest ..............   Passed   65.05 sec
      Start  2: BackendTest
 2/34 Test  #2: BackendTest .........................   Passed    5.42 sec
      Start  3: BasicIRTest
 3/34 Test  #3: BasicIRTest .........................   Passed    0.09 sec
      Start  4: Caffe2ImporterTest
 4/34 Test  #4: Caffe2ImporterTest ..................   Passed   11.51 sec
      Start  5: DeviceManagerTest
 5/34 Test  #5: DeviceManagerTest ...................   Passed    1.93 sec
      Start  6: ThreadPoolExecutorTest
 6/34 Test  #6: ThreadPoolExecutorTest ..............   Passed    5.08 sec
      Start  7: Float16Test
 7/34 Test  #7: Float16Test .........................   Passed    0.03 sec
      Start  8: GemmTest
 8/34 Test  #8: GemmTest ............................   Passed    0.22 sec
      Start  9: GlowOnnxifiManagerTest
 9/34 Test  #9: GlowOnnxifiManagerTest ..............   Passed    0.18 sec
      Start 10: GradCheckTest
10/34 Test #10: GradCheckTest .......................   Passed   15.40 sec
      Start 11: GraphGradTest
11/34 Test #11: GraphGradTest .......................   Passed    0.22 sec
      Start 12: GraphOptzTest
12/34 Test #12: GraphOptzTest .......................   Passed    0.12 sec
      Start 13: GraphSchedulerTest
13/34 Test #13: GraphSchedulerTest ..................   Passed    0.03 sec
      Start 14: GraphTest
14/34 Test #14: GraphTest ...........................   Passed    3.00 sec
      Start 15: HostManagerTest
15/34 Test #15: HostManagerTest .....................   Passed   13.79 sec
      Start 16: HyphenTest
16/34 Test #16: HyphenTest ..........................   Passed    3.47 sec
      Start 17: IROptTest
17/34 Test #17: IROptTest ...........................   Passed    0.05 sec
      Start 18: ImageTest
18/34 Test #18: ImageTest ...........................   Passed    1.08 sec
      Start 19: LLVMIRGenTest
19/34 Test #19: LLVMIRGenTest .......................   Passed    0.05 sec
      Start 20: MLTest
20/34 Test #20: MLTest ..............................   Passed  141.01 sec
      Start 21: MemoryAllocatorTest
21/34 Test #21: MemoryAllocatorTest .................   Passed    0.08 sec
      Start 22: OCLTest
22/34 Test #22: OCLTest .............................   Passed    0.64 sec
      Start 23: OnnxImporterTest
23/34 Test #23: OnnxImporterTest ....................   Passed    0.51 sec
      Start 24: OperatorGradTest
24/34 Test #24: OperatorGradTest ....................   Passed    0.14 sec
      Start 25: OperatorTest
25/34 Test #25: OperatorTest ........................   Passed   35.78 sec
      Start 26: PartitionerTest
26/34 Test #26: PartitionerTest .....................   Passed    0.20 sec
      Start 28: ProvisionerTest
27/34 Test #28: ProvisionerTest .....................   Passed    2.25 sec
      Start 29: QuantizationTest
28/34 Test #29: QuantizationTest ....................   Passed   17.17 sec
      Start 30: TensorsTest
29/34 Test #30: TensorsTest .........................   Passed    1.28 sec
      Start 31: TensorPoolTest
30/34 Test #31: TensorPoolTest ......................   Passed    0.03 sec
      Start 32: ThreadPoolTest
31/34 Test #32: ThreadPoolTest ......................   Passed    0.05 sec
      Start 33: TraceEventsTest
32/34 Test #33: TraceEventsTest .....................   Passed   32.11 sec
      Start 34: TypeAToTypeBFunctionConverterTest
33/34 Test #34: TypeAToTypeBFunctionConverterTest ...   Passed    0.15 sec
      Start 35: UtilsTest
34/34 Test #35: UtilsTest ...........................   Passed    0.07 sec

100% tests passed, 0 tests failed out of 34

Total Test time (real) = 358.24 sec
```
Pull Request resolved: #3118

Differential Revision: D15836207

Pulled By: SplitInfinity

fbshipit-source-id: 7bfa3c6ed5583d6a8f42b1f712f359e8e1d10b47
@agureja agureja mentioned this pull request Oct 16, 2019
Closed
@Verma-Rajat Verma-Rajat mentioned this pull request Nov 28, 2019
Closed
@ponnamsairam ponnamsairam mentioned this pull request Dec 23, 2019
Closed
@XiZiler XiZiler mentioned this pull request Dec 26, 2019
Closed
@ponnamsairam ponnamsairam mentioned this pull request Jan 8, 2020
Open
@notaJiminLee notaJiminLee mentioned this pull request Dec 8, 2020
Open
@vjayd vjayd mentioned this pull request Mar 29, 2021
Closed
@mulanxiaodingdang mulanxiaodingdang mentioned this pull request Apr 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd requested changes

@zem7 zem7 Awaiting requested review from zem7

@jspark1105 jspark1105 Awaiting requested review from jspark1105

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadavrot @compnerd @facebook-github-bot