[Variable] Remove the tensor initialization from Variable. NFC. #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavrot
force-pushed
the
cleanup_variable
branch
from
2da9c23 to
8a9b391
Compare
|
Feel free to merge after resolving conflicts, it's easy to get conflicts with this PR. |
nadavrot
force-pushed
the
cleanup_variable
branch
from
8a9b391 to
c882c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the initialization code from Variable and moves it to the code that creates the variable. After this change Tensors needs to be initialized externally and not by the Variable constructor like they are today. This is a pretty big patch that touches many many files, but most of the changes are mechanical.
I tried to make this patch as simple as possible and there are still a few things that we need to clean up. For example, the default values for arguments don't make sense in a few places. We should change the boolean training flag to an enum, etc.