Skip to content

[Placeholder] Teach the OCL and CPU backends to handle Placeholders. #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

nadavrot
Copy link
Contributor

@nadavrot nadavrot commented Sep 9, 2018

Description: This PR adds PH execution engine support for the CPU and OpenCL backends.
Testing: Added a unit test.
Documentation: None.

This PR depends on #1597 (and includes it). #1597 needs to land before this PR is reviewed.

Copy link
Contributor

@hegemanjwh2 hegemanjwh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@nadavrot
Copy link
Contributor Author

nadavrot commented Sep 9, 2018

@hegemanjwh2 Thank you for the review of the PRs this evening.

@nadavrot nadavrot merged commit 2ceff6b into pytorch:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants