Skip to content

[Placeholder] Migrate more tests to the new API. #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

nadavrot
Copy link
Contributor

Description: Migrate more tests to the new API. Get rid of additional usages of getVariable().
Testing: This commit updates tests.
Documentation: None.

Copy link
Contributor

@bertmaher bertmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one question below:

@@ -1998,6 +1998,379 @@ SaveNode *Function::createSave(Context &ctx, llvm::StringRef name,
return addNode(new SaveNode(name, input, dest));
}

void Function::createGRU(Context &ctx, llvm::StringRef namePrefix,

This comment was marked as off-topic.

This comment was marked as off-topic.

@nadavrot nadavrot merged commit 9835ac5 into pytorch:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants