[Placeholder] Remove the ability to save into variables. #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable. This commit removes the SaveNode constructor that saves into a variable. It also fixes the lowering method and makes it create a placeholder for the GSUM storage. It also renames createSaveNodePH into createSaveNode. At the moment we need to initialize the context after lowering because lowering creates new placeholders. When we migrate the context into the execution method we'll be able to move the initialization outside of the compilation code.
nadavrot
force-pushed
the
delete_save_variable
branch
from
ebc2baf to
be9ffd9
Compare
jfix71
reviewed
Oct 4, 2018
| optimizeFunction(mode, F); | ||
| // Make sure that the context has backing tensors for all placeholders. | ||
| ctx.allocate(M_.getPlaceholders()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@nadavrot the check for "up to date" branch is gone, so it should be good to merge after squashing. edit: No squashing is required. |
rdzhabarov
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[Placeholder] Remove the support for variables from SaveNode.
[Placeholder] Remove the ability to create SaveNode that saves into a variable.
This commit removes the SaveNode constructor that saves into a variable.
It also fixes the lowering method and makes it create a placeholder for
the GSUM storage. It also renames createSaveNodePH into createSaveNode.
At the moment we need to initialize the context after lowering because
lowering creates new placeholders. When we migrate the context into the
execution method we'll be able to move the initialization outside of the
compilation code.
Testing: Ran ninja check and run.sh
Documentation: None.
#1334