Create GlowErr type with informational error code enum #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackm321
changed the title
jfix71
reviewed
Jan 18, 2019
include/glow/Support/Error.h
Outdated
| } | ||
| } | ||
|
|
||
| GlowErr(llvm::StringRef fileName, int32_t lineNumber, llvm::StringRef message, |
There was a problem hiding this comment.
lineNumber is int32_t, while lineNumber_ is size_t.
lib/Support/Error.cpp
Outdated
| return llvm::formatv("Error at file {0} line {1} \"{2}\"", file, line, str); | ||
| } | ||
|
|
||
| char GlowErr::ID = 0; |
There was a problem hiding this comment.
Can you add a comment explaining what this is for?
rdzhabarov
approved these changes
Jan 18, 2019
include/glow/Support/Error.h
Outdated
| class GlowErr final : public llvm::ErrorInfo<GlowErr> { | ||
| public: | ||
| /// Used by ErrorInfo::classID. | ||
| static char ID; |
There was a problem hiding this comment.
can you make that uint8_t.
include/glow/Support/Error.h
Outdated
| static char ID; | ||
| /// An enumeration of error codes representing various possible errors that | ||
| /// could occur. | ||
| enum EC { |
There was a problem hiding this comment.
can this be enum class and also no need to explicit values.
There was a problem hiding this comment.
ErrorCode would be more descriptive.
jackm321
force-pushed
the
create_glow_error
branch
from
c37cd08 to
312b6ca
Compare
jackm321
force-pushed
the
create_glow_error
branch
from
312b6ca to
7a58a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Create an llvm::Error that holds a string and/or an enum that classifies the error so that this information can be used to send correct ONNXIFI statuses.
In followups, handle error codes to send ONNXIFI statuses. Use error codes in the rest of model loading stack.
Testing:
ninja allDocumentation:
doxygen