[tests] Include private headers using relative paths #2287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: While it's best for tests to only use the "public" headers of a library, it sometimes makes sense to use the private/internal headers directly. Instead of adding to the include path via cmake, let's refer to them using relative paths like
../../lib/Foo/Bar.h
. This seems to be LLVM's approach, and I see two advantages:Testing: ninja all
Documentation: n/a