Skip to content

[Graph Partitioner] Improve initial partitions and updated unittest #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2019
Merged

[Graph Partitioner] Improve initial partitions and updated unittest #2307

merged 1 commit into from
Jan 26, 2019

Conversation

beicy
Copy link
Contributor

@beicy beicy commented Jan 25, 2019

Description:
In this PR:

  1. Updated the unittest : when create a FC op, use the interface which allows the weights and bias to be constant.
  2. Improved the initial partitioning: after BFS, if the memory consumption of all the nodes in one level exceeds the device memory constraints, separates this level in initial partitions. After this, each initial partitions is guaranteed to meet memory constraints.

Testing:
Added unittest.

Documentation:
#2298
[Optional Fixes #issue]

Please see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.

@beicy beicy merged commit d803d6c into pytorch:master Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadavrot nadavrot nadavrot approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beicy @nadavrot @facebook-github-bot