Fix Unchecked errors in Partitioner #3505 #3511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackm321
reviewed
Sep 14, 2019
| RETURN_ERR_IF_NOT(subF->verify(), | ||
| strFormat("Conversion led to invalid function: %s", | ||
| subF->getName().str().data())); | ||
| if (!subF->verify()) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lib/Partitioner/Partitioner.cpp
Outdated
| subF->getName().str().data())); | ||
| if (!subF->verify()) { | ||
| return MAKE_ERR(GlowErr::ErrorCode::PARTITIONER_ERROR, | ||
| "Conversion led to invalid function" + |
lib/Partitioner/Partitioner.cpp
Outdated
| subF, strFormat("Invalid function name %s.", node->name.data())); | ||
| if (!subF) { | ||
| return MAKE_ERR(GlowErr::ErrorCode::PARTITIONER_ERROR, | ||
| "Invalid function name" + node->name); |
There was a problem hiding this comment.
space after "name"
Also same comment as above and why not continue to use strFormat?
There was a problem hiding this comment.
This one looks simpler :)
tests/unittests/PartitionerTest.cpp
Outdated
| @@ -343,7 +344,10 @@ TEST_F(PartitionerTest, Error1) { | |||
| Partitioner myPartitioner(&EEP.getModule(), devices); | |||
| CompilationContext cctx; | |||
| auto dagList = myPartitioner.partition(cctx); | |||
| EXPECT_FALSE((bool)dagList); | |||
| ASSERT_FALSE(handleErrors(dagList.takeError(), [](const GlowErr &GE) { | |||
|
I have fixed these unchecked errors in #3515 |
|
But since this introduces |
jackm321
approved these changes
Sep 16, 2019
| @@ -250,6 +250,7 @@ TEST_F(PartitionerTest, Basic2) { | |||
| Partitioner myPartitioner(&EEP.getModule(), devices, /* saturateHost */ true); | |||
| CompilationContext cctx; | |||
| auto dagList = myPartitioner.partition(cctx); | |||
| EXPECT_TRUE((bool)dagList); | |||
There was a problem hiding this comment.
@beicy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix unchecked errors in Partitioner, rewrite the way to report an error.
#3505
Documentation:
[Optional Fixes]
Test Plan:
ninja test.
Please see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.