[Onnxifi] Better error message #3514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertmaher
reviewed
Sep 14, 2019
lib/Onnxifi/Base.cpp
Outdated
| @@ -157,8 +157,18 @@ onnxStatus Graph::setIOAndRun(uint32_t inputsCount, | |||
| } | |||
|
|
|||
| if (inOnnxTensorSize > inPhPtr->getType()->size()) { | |||
| std::stringstream ss; | |||
| for (const auto i : inOnnxTensorDims) { | |||
| ss << i << ", "; | |||
There was a problem hiding this comment.
Would be nicer without the trailing comma, too bad we don't have folly::join :-)
bertmaher
approved these changes
Sep 14, 2019
There was a problem hiding this comment.
@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Give better error message when input tensor is larger than the compiled spec. Adding shape will help on which dimension we got wrong.
Documentation:
[Optional Fixes #issue]
Test Plan:
Please see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.