Skip to content

Add isDataParallel to node generation #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shajrawi
Copy link
Contributor

cherry-pick of the isDataParallel change from #3503 : it is an independent feature that we can merge per the offline discussion with @opti-mix

Test Plan:
ninja test

@shajrawi shajrawi requested a review from opti-mix October 31, 2019 23:17
@shajrawi shajrawi force-pushed the data_par_node branch 3 times, most recently from 85dea01 to a189eda Compare November 1, 2019 00:02
Copy link
Contributor

@opti-mix opti-mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now we have a feature-parity with InstrGen when it comes to data parallel operations!

LGTM

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shajrawi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@shajrawi merged this pull request in 2b960af.

vdantu pushed a commit to vdantu/glow that referenced this pull request Jul 12, 2020
Summary:
cherry-pick of the isDataParallel change from pytorch#3503 : it is an independent feature that we can merge per the offline discussion with opti-mix
Pull Request resolved: pytorch#3715

Test Plan: ninja test

Differential Revision: D18263215

Pulled By: shajrawi

fbshipit-source-id: 52947ba5419c55eaf76048411d09a40a862fda1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants