Revert "Add dynamic buffer support to OCL Backend (#3765)" #3784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd69664.
There was a problem hiding this comment.
@nickgg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
…torch#3784) Summary: This reverts commit bd69664. I had thought that I had gotten the last POCL issue in pytorch#3765, but I had not. Reverting to fix the OCL build. Honestly this last issue (AMD/POCL requires sub buffers to aligned) seems to torpedo the whole idea, I can't think of any way to handle Glow TensorViews on the host - which means passing buffer + offset everywhere we pass a buffer below. Essentially this would mean rewriting the whole thing. Very frustrating since that alignment restriction on subBuffers makes no sense, and no other OCL implementation has it. Pull Request resolved: pytorch#3784 Differential Revision: D18480248 Pulled By: nickgg fbshipit-source-id: 9b05009ea901a0f477805e6c946faac34d9bc303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bd69664.
I had thought that I had gotten the last POCL issue in #3765, but I had not. Reverting to fix the OCL build.
Honestly this last issue (AMD/POCL requires sub buffers to aligned) seems to torpedo the whole idea, I can't think of any way to handle Glow TensorViews on the host - which means passing buffer + offset everywhere we pass a buffer below. Essentially this would mean rewriting the whole thing.
Very frustrating since that alignment restriction on subBuffers makes no sense, and no other OCL implementation has it.