[TensorLayout] Mark MatMul and Pad as nodes that can operate on any layout #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayout While they are not data parallel, they can operate on any order of dimensions.
There was a problem hiding this comment.
@shajrawi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
If I'm not too tiresome :) can you take a look over all the operators currently supported by Glow and verify if there is one which might have slipped from being marked as 'any layout'? Thanks for fixing this! |
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
…3832) Summary: While they are not data parallel, they can operate on any order of dimensions. Fixes pytorch#3804 Pull Request resolved: pytorch#3832 Test Plan: ``` model-compiler -backend=CPU -model=model1.onnx -emit-bundle=build model-compiler -backend=CPU -model=model2.onnx -emit-bundle=build ``` Differential Revision: D18765346 Pulled By: shajrawi fbshipit-source-id: c44713036b00918ac14ef62f117982d0dfcfc062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While they are not data parallel, they can operate on any order of dimensions.
Fixes #3804
Test Plan: