Move Expected IValue helper methods to common #4212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move methods used to deal with Expected IVavlues in the PyTorchModelLoader to Common so that they can be used in other code as well Reviewed By: yinghai Differential Revision: D20068995 fbshipit-source-id: e76802cef1fbfbfdb755a0e9e0aa3a4495580902
|
This pull request was exported from Phabricator. Differential Revision: D20068995 |
|
This pull request has been merged in 0546c76. |
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
Summary: Pull Request resolved: pytorch#4212 Move methods used to deal with Expected IVavlues in the PyTorchModelLoader to Common so that they can be used in other code as well Reviewed By: yinghai Differential Revision: D20068995 fbshipit-source-id: 2926911bb918eaa21eda3ca381f2bea239e89454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move methods used to deal with Expected IVavlues in the
PyTorchModelLoader to Common so that they can be used in other code as well
Reviewed By: yinghai
Differential Revision: D20068995