Skip to content

Defaults #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2017
Merged

Defaults #44

merged 4 commits into from
Oct 23, 2017

Conversation

compnerd
Copy link
Contributor

No description provided.

@nadavrot
Copy link
Contributor

@compnerd I like the change to add a default type to get handle.

I think that we can make DefaultFloat == float all over the code. When I started working on this I assumed that we would need this flexibility, but now I see that everything is wired for the case where FloatTy = float. When we load numbers from caffe models they are assumed to be float. So, I suggest just getting rid of DefaultFloat and making it equal to float. ok?

Rather than explicitly specifying the floating point precision
everywhere, assume the default unless otherwise specified.
Remove DefaultFloatTy and inline the default typedef into all current
uses.
@compnerd
Copy link
Contributor Author

Sounds reasonable enough to me. I can remove the use of the DefaultFloatTy. I wonder if we can de-templateize some of the declarations for a code-size win as well.

@nadavrot
Copy link
Contributor

@compnerd Which declarations?

@compnerd
Copy link
Contributor Author

Some of the handle returning types were templated IIRC, but I didn't track them closely. I think we could do that as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants