Skip to content

Support: remove custom RTTI handling #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2017
Merged

Support: remove custom RTTI handling #52

merged 1 commit into from
Oct 28, 2017

Conversation

compnerd
Copy link
Contributor

Reuse the LLVM custom RTTI scheme which the internal version was
modelled after. NFC.

@compnerd compnerd requested a review from nadavrot October 28, 2017 18:32
nadavrot
nadavrot approved these changes Oct 28, 2017
View reviewed changes
Copy link
Contributor

@nadavrot nadavrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I would sprinkle:

using isa = llvm::isa;

in a few places to make the code cleaner.

@compnerd
Support: remove custom RTTI handling
7d1bbe3 
Reuse the LLVM custom RTTI scheme which the internal version was
modelled after.  NFC.
@compnerd compnerd merged commit 88d7ee8 into pytorch:master Oct 28, 2017
@compnerd compnerd deleted the rtti branch October 28, 2017 23:07
@mulanxiaodingdang mulanxiaodingdang mentioned this pull request Apr 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadavrot nadavrot nadavrot approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @nadavrot @facebook-github-bot