Skip to content

[cleanup] Remove depth parameter from ConvolutionNode. #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2018
Merged

[cleanup] Remove depth parameter from ConvolutionNode. #884

merged 1 commit into from
Apr 12, 2018

Conversation

artemrakhov-glow
Copy link
Contributor

NFC.
Depth parameter is not coming from ONNX or Caffe2 proto. We set it ourselves, then assert it, verify it, then don't use it in backends. It's essentially odim.c (or filterDims[0] or biasDims[0])

@@ -10,7 +10,7 @@ void CPUConvDKKC8Node::verify() const {
ShapeNHWC odim(getResult().getType()->dims());
auto outSz = calculateConvOutputDims(idim.h, idim.w, getKernel(), getStride(),
getPad());
ShapeNHWC exp(idim.n, outSz.first, outSz.second, getDepth());

This comment was marked as off-topic.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants