Skip to content

Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h #39471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pbelevich opened this issue Jun 3, 2020 · 0 comments
Closed

Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h #39471

pbelevich opened this issue Jun 3, 2020 · 0 comments
Assignees
@pbelevich
Labels
module: cpp Related to C++ API triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pbelevich
Copy link
Contributor

pbelevich commented Jun 3, 2020 •
edited by pytorch-probot bot
Loading

If C++ extension uses ATen/Parallel.h it requires AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB which were used to build installed PyTorch. Currently they are unavailable after build, so these values should be included into ATen/Config.h.in

cc @yf225 @glaringlee
@pbelevich pbelevich self-assigned this Jun 3, 2020
@pbelevich pbelevich mentioned this issue Jun 4, 2020
Closed
@mrshenli mrshenli added module: cpp Related to C++ API triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 4, 2020
@pbelevich pbelevich mentioned this issue Jun 5, 2020
Closed
pbelevich added a commit that referenced this issue Jun 6, 2020
@pbelevich
Update on "Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_…
8d04c86 
…NATIVE_TBB to ATen/Config.h"

Fixes #39471




[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 8, 2020
@pbelevich
Update on "Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_…
311d9af 
…NATIVE_TBB to ATen/Config.h"

Fixes #39471

Manually tested with https://github.com/pytorch/csprng




[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 9, 2020
@pbelevich
Update on "Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_…
f571c35 
…NATIVE_TBB to ATen/Config.h"

Fixes #39471

Manually tested with https://github.com/pytorch/csprng




[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 9, 2020
@pbelevich
Update on "Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_…
981790c 
…NATIVE_TBB to ATen/Config.h"

Fixes #39471

Manually tested with https://github.com/pytorch/csprng




[ghstack-poisoned]
@pbelevich pbelevich mentioned this issue Jun 12, 2020
Closed
@pbelevich pbelevich reopened this Jun 14, 2020
@pbelevich pbelevich mentioned this issue Jun 15, 2020
Closed
pbelevich added a commit that referenced this issue Jun 15, 2020
@pbelevich
Update on "[Yet Another Reland] Include AT_PARALLEL_OPENMP/AT_PARALLE…
8806993 
…L_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h"

Fixes #39471

Reland of #39612 and #39881


Differential Revision: [D22050656](https://our.internmc.facebook.com/intern/diff/D22050656)

[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 16, 2020
@pbelevich
Update on "[Yet Another Reland] Include AT_PARALLEL_OPENMP/AT_PARALLE…
616629a 
…L_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h"

Fixes #39471

Reland of #39612 and #39881


Differential Revision: [D22050656](https://our.internmc.facebook.com/intern/diff/D22050656)

[ghstack-poisoned]
@pbelevich pbelevich mentioned this issue Jun 16, 2020
Closed
pbelevich added a commit that referenced this issue Jun 16, 2020
@pbelevich
Update on "[Reland #3] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/…
a15d83d 
…AT_PARALLEL_NATIVE_TBB to ATen/Config.h"

Fixes #39471

Reland of #39612 #39881 and #40045


Differential Revision: [D22076711](https://our.internmc.facebook.com/intern/diff/D22076711)

[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 16, 2020
@pbelevich
Update on "[Reland #3] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/…
c9f0a84 
…AT_PARALLEL_NATIVE_TBB to ATen/Config.h"

Fixes #39471

Reland of #39612 #39881 and #40045


Differential Revision: [D22076711](https://our.internmc.facebook.com/intern/diff/D22076711)

[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 16, 2020
@pbelevich
Update on "[Reland #3] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/…
e064c13 
…AT_PARALLEL_NATIVE_TBB to ATen/Config.h"

Fixes #39471

Reland of #39612 #39881 and #40045


Differential Revision: [D22076711](https://our.internmc.facebook.com/intern/diff/D22076711)

[ghstack-poisoned]
pbelevich added a commit that referenced this issue Jun 16, 2020
@pbelevich
Update on "[Reland #3] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/…
7bd9b9e 
…AT_PARALLEL_NATIVE_TBB to ATen/Config.h"

Fixes #39471

Reland of #39612 #39881 and #40045


Differential Revision: [D22076711](https://our.internmc.facebook.com/intern/diff/D22076711)

[ghstack-poisoned]
@pbelevich pbelevich mentioned this issue Jun 18, 2020
Closed
facebook-github-bot pushed a commit that referenced this issue Jun 19, 2020
@pbelevich @facebook-github-bot
[Reland #4] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL…
ccea372 
…_NATIVE_TBB to ATen/Config.h (#40211)

Summary:
Fixes #39471

Reland of #39612 #39881 #40045 #40122

Proof: [green TBB test](https://app.circleci.com/pipelines/github/pytorch/pytorch/182769/workflows/ae9f4f7a-791a-49df-9625-e2f0a51e70e7/jobs/5910591/steps)
Pull Request resolved: #40211

Reviewed By: malfet

Differential Revision: D22128537

Pulled By: pbelevich

fbshipit-source-id: 98c589405daafc2c81f76e1d5c1aef5e57065351
xwang233 pushed a commit to xwang233/pytorch that referenced this issue Jun 20, 2020
@pbelevich @xwang233
[Yet Another Reland] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT…
99c8173 
…_PARALLEL_NATIVE_TBB to ATen/Config.h (pytorch#40045)

Summary:
Pull Request resolved: pytorch#40045

Fixes pytorch#39471

Reland of pytorch#39612 and pytorch#39881

Test Plan: Imported from OSS

Differential Revision: D22050656

Pulled By: pbelevich

fbshipit-source-id: 274bc0733c37ef6c87deb3344bb49ca9107e257b
xwang233 pushed a commit to xwang233/pytorch that referenced this issue Jun 20, 2020
@pbelevich @xwang233
[Reland pytorch#4] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_P…
501c44b 
…ARALLEL_NATIVE_TBB to ATen/Config.h (pytorch#40211)

Summary:
Fixes pytorch#39471

Reland of pytorch#39612 pytorch#39881 pytorch#40045 pytorch#40122

Proof: [green TBB test](https://app.circleci.com/pipelines/github/pytorch/pytorch/182769/workflows/ae9f4f7a-791a-49df-9625-e2f0a51e70e7/jobs/5910591/steps)
Pull Request resolved: pytorch#40211

Reviewed By: malfet

Differential Revision: D22128537

Pulled By: pbelevich

fbshipit-source-id: 98c589405daafc2c81f76e1d5c1aef5e57065351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbelevich pbelevich

Labels
module: cpp Related to C++ API triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
2 participants
@pbelevich @mrshenli