Override tests in test/test_overrides.py failing for some functions #74122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mikaylagawarecki opened this issue Mar 11, 2022 · 1 comment

Assignees

Labels

module: tests module: __torch_function__ triaged

Contributor

mikaylagawarecki commented Mar 11, 2022 •

edited by pytorch-bot bot

Loading

🐛 Describe the bug

generate_tensor_like_override_tests(TestTorchFunctionOverride) in test/test_overrides.py was disabled since #64841. As a result, the associated tests have not been run since then. Re-enabling this in #74121 surfaced issues, particularly with

TestTorchFunctionOverride.test_torch_functional_histogramdd
TestTorchFunctionOverride.test_Tensor_storage_type

These are skipped for now but should be fixed, opening this issue to track.

2022-03-11T20:23:14.4580034Z ERROR [0.001s]: test_torch_functional_histogramdd (main.TestTorchFunctionOverride)
2022-03-11T20:23:14.4580499Z ----------------------------------------------------------------------
2022-03-11T20:23:14.4580766Z Traceback (most recent call last):
2022-03-11T20:23:14.4580990Z File "test_overrides.py", line 646, in test
2022-03-11T20:23:14.4581189Z ret = func(*func_args, **kwargs)
2022-03-11T20:23:14.4581762Z File "/opt/conda/lib/python3.7/site-packages/torch/functional.py", line 464, in histogramdd
2022-03-11T20:23:14.4582024Z if bins and isinstance(bins[0], int):
2022-03-11T20:23:14.4582308Z TypeError: 'TensorLike' object is not subscriptable
2022-03-11T20:23:14.4582453Z
2022-03-11T20:23:14.4582543Z ======================================================================
2022-03-11T20:23:14.4582785Z FAIL [0.001s]: test_Tensor_storage_type (main.TestTorchFunctionOverride)
2022-03-11T20:23:14.4583150Z ----------------------------------------------------------------------
2022-03-11T20:23:14.4583385Z Traceback (most recent call last):
2022-03-11T20:23:14.4583601Z File "test_overrides.py", line 655, in test
2022-03-11T20:23:14.4583832Z self.assertEqual(ret, -1)
2022-03-11T20:23:14.4584208Z File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2154, in assertEqual
2022-03-11T20:23:14.4584470Z msg=msg,
2022-03-11T20:23:14.4584794Z File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
2022-03-11T20:23:14.4585070Z raise error_metas[0].to_error()
2022-03-11T20:23:14.4585349Z AssertionError: Object comparison failed: <class 'int'> != -1
2022-03-11T20:23:14.4585502Z

Versions

CI

cc @mruberry @hameerabbasi @rgommers @peterbell10

The text was updated successfully, but these errors were encountered:

mikaylagawarecki added the module: tests label

ezyang added triaged module: __torch_function__ labels

Contributor

ezyang commented Mar 12, 2022

peterbell10 self-assigned this

peterbell10 mentioned this issue

Restore TestTorchFunctionOverride #74202

Closed

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

f6b76f7

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

820de93

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: 039df5c
Pull Request resolved: #74202

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

b695e7a

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

ac9ef25

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

40a1ae0

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: 035a287
Pull Request resolved: #74202

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

97d6086

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

21bd226

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

50a294f

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

18bd69b

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

7a44f4b

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

6971a10

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: 90f155f
Pull Request resolved: #74202

peterbell10 added a commit that referenced this issue


          Update base for Fix int-list overloading with TensorList on "Restore …

fe5da32

…TestTorchFunctionOverride"

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Fix int-list overloading with TensorList on "Restore TestTorchFunctio…

9ed4a7e

…nOverride"

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

b6b1073

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

5bc6a8a

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: cd24441
Pull Request resolved: #74202

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

55857c1

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

c492830

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

3b86079

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: cd24441
Pull Request resolved: #74202

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

1112fda

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

f984598

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Restore TestTorchFunctionOverride

3b21887

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: 11dd6bd
Pull Request resolved: #74202

peterbell10 added a commit to peterbell10/pytorch that referenced this issue


          Restore TestTorchFunctionOverride

c30fa1b

Fixes pytorch#74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

ghstack-source-id: 11dd6bd
Pull Request resolved: pytorch#74202

peterbell10 added a commit that referenced this issue


          Update base for Update on "Restore TestTorchFunctionOverride"

12f4349

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

peterbell10 added a commit that referenced this issue


          Update on "Restore TestTorchFunctionOverride"

2ca1ad9

Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

[ghstack-poisoned]

pytorchmergebot closed this as completed in

bf16552

facebook-github-bot pushed a commit that referenced this issue


          Restore TestTorchFunctionOverride (#74202)

d768c5a

Summary:
Fixes #74122

This re-enables TestTorchFunctionOverride and fixes a bunch of test failures
that had crept in while it was disabled.

Pull Request resolved: #74202

Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf16552617e0f82e6963762b6d40a8ae39105fae

Reviewed By: atalman

Differential Revision: D35359961

fbshipit-source-id: 39e7028618c4f4020a6fe57f0afd3901b84b28f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment