[Caffe2] Remove C++14 feature #10022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bddppq
approved these changes
Jul 30, 2018
|
It was not a test error, just build time warning. I saw that in pr/caffe2-onnx-py2-gcc5-ubuntu16.04-test |
There was a problem hiding this comment.
yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
approved these changes
Jul 30, 2018
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: Which test should I look at, bddppq? Pull Request resolved: pytorch#10022 Reviewed By: bddppq Differential Revision: D9068732 Pulled By: yinghai fbshipit-source-id: 241ef72c7fac0ed0b8c58ecdffbb5e24eb956217
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Which test should I look at, bddppq? Pull Request resolved: pytorch#10022 Reviewed By: bddppq Differential Revision: D9068732 Pulled By: yinghai fbshipit-source-id: 241ef72c7fac0ed0b8c58ecdffbb5e24eb956217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which test should I look at, @bddppq?